search

mhammond / pywin32

Python for Windows (pywin32) Extensions
5.07k stars 799 forks source link

feat: add MOD_NOREPEAT (RegisterHotKey) constant #2427

Closed CristiFati closed 6 days ago

CristiFati commented 6 days ago

While working on [SO]: How to listen for hotkeys in a separate thread using Python with Win32 API and PySide6, noticed that MOD_NOREPEAT is missing. Adding it.

The change is childishly trivial, PR work is more complex than the change itself, so if I encounter this situation in the future what should I do?

  1. Submit a PR for each such change (and risk spamming with PRs (BTW, sorry if I did that))

  2. Wait for a while (until a bunch of such trivial changes pile up) and create one PR for all of them

    • Variant: Submit the trivial change as part of an unrelated PR
mhammond commented 6 days ago

Whatever works for you, but the volume of these PRs from you is no where near a problem yet! Feel free to ping me if they fall through the cracks.