mhammond / pywin32

Python for Windows (pywin32) Extensions
5.08k stars 800 forks source link

Restore shipping help file #2432

Open Avasam opened 1 week ago

Avasam commented 1 week ago

This restores shipping help file to the users by including its build in the setuptools build, rather than it being a separate manual step as before.

This also means that we should theorically be able to update the online doc from GitHub artifacts instead of downloading/installing from PyPI. (I think that'll require merging the workflow files though). If you'd like that, I can merge the workflows in this PR.

Avasam commented 1 week ago

"but it worked on my machine!"... (and I tried to make sure to test from clean installs !) I think it has something to do with the import pywin32_bootstrap hack. At least the basic idea of pointing a path file to the build folder works, as its not failing on importing isapi

It's also annoyingly basically the same error as in https://github.com/mhammond/pywin32/pull/2392