search

mhammond / pywin32

Python for Windows (pywin32) Extensions
5.04k stars 796 forks source link

swig arg converters leak on error converting args #353

Open ghost opened 16 years ago

ghost commented 16 years ago

Roger noticed that in the generated SWIG code, most converters return NULL, even if other args required cleanup. This can be fixed but (a) it relies on args being initialized and (b) it may cause bloat.

Re a), Roger also notes in win32gui will need some work, though. The freearg section for STRING_OR_ATOM_CW checks the result, but HWND doesn't have in initializer. b) can somewhat be mitigated by using "optimize for size" for these files. Both these combined cause too much risk for build 211, so adding the patch here. Note the patch does most of pywintypes.i, but we need to check the others.

Reported by: mhammond

Original Ticket: "pywin32/bugs/353":https://sourceforge.net/p/pywin32/bugs/353

ghost commented 16 years ago

patch cleaning up most strings

Original comment by: mhammond

Avasam commented 7 months ago

Tagging @mhammond as the original Creator of the issue on SourceForge.