mhardcastle / ddf-pipeline

LOFAR pipeline using killms/ddfacet
GNU General Public License v2.0
24 stars 20 forks source link

part a) pipeline issues with latest DDF/kMS (early 2023 versions) #294

Closed twshimwell closed 1 year ago

twshimwell commented 1 year ago

One issue im seeing with the new software is:

MS PROPERTIES:

Traceback (most recent call last): File "/usr/local/src/killMS/killMS/kMS.py", line 1558, in main(OP=OP,MSName=MSName) File "/usr/local/src/killMS/killMS/kMS.py", line 793, in main Solver=ClassWirtingerSolver(VS,SM,PolMode=options.PolMode, File "/usr/local/src/killMS/killMS/Wirtinger/ClassWirtingerSolverLoops.py", line 65, in init ClassWirtingerSolver.init(self,*args,**kwargs) File "/usr/local/src/killMS/killMS/Wirtinger/ClassWirtingerSolver.py", line 148, in init self.SolPredictMachine=ClassSolPredictMachine.ClassSolPredictMachine(GD) File "/usr/local/src/killMS/killMS/Wirtinger/ClassSolPredictMachine.py", line 38, in init stop NameError: name 'stop' is not defined

mhardcastle commented 1 year ago

This is usually @cyriltasse 's way of marking some code that he's debugging or hasn't written yet. We shouldn't be hitting it in production.

cyriltasse commented 1 year ago

I did not hit this one did you fix it with your changes @mhardcastle ?

mhardcastle commented 1 year ago

No I didn't, I didn't see it either in my tests.

twshimwell commented 1 year ago

did you get past the calibration after image_phase?

mhardcastle commented 1 year ago

I didn't...

cyriltasse commented 1 year ago

Oh yeah perhaps I did not get there yet :)

twshimwell commented 1 year ago

sorry id skipped ahead by doing some of the failing steps with the old kms/ddf

cyriltasse commented 1 year ago

Ok I've hit and fixed this one - and I've recompiled the ddf_dev.sif image!