search

mharen / jquery-endless-inputs-plugin

Simple jQuery plugin for cloning inputs as they are filled in
http://blog.wassupy.com/
GNU General Public License v2.0
1 stars 0 forks source link

Add an option for maximum #1

Closed xdumaine closed 13 years ago

xdumaine commented 13 years ago

Requesting an option for a maximum number of clones. i.e, endlessInputs({ max:5 }) (correct syntax?) to allow a maximum of 5 clones.

xdumaine commented 13 years ago

I'm willing to try to implement this.

mharen commented 13 years ago

This will definitely be added.

Thanks, Michael Haren

On Thu, Aug 4, 2011 at 1:31 PM, xdumaine < reply@reply.github.com>wrote:

Requesting an option for a maximum number of clones. i.e, endlessInputs({ max:5 }) (correct syntax?) to allow a maximum of 5 clones.

Reply to this email directly or view it on GitHub: https://github.com/mharen/jquery-endless-inputs-plugin/issues/1

xdumaine commented 13 years ago

I coded it. I'm not familiar with github but I could try to submit a patch.

-Xander

On Aug 4, 2011, at 1:32 PM, "mharen" reply@reply.github.com wrote:

This will definitely be added.

Thanks, Michael Haren

On Thu, Aug 4, 2011 at 1:31 PM, xdumaine < reply@reply.github.com>wrote:

Requesting an option for a maximum number of clones. i.e, endlessInputs({ max:5 }) (correct syntax?) to allow a maximum of 5 clones.

Reply to this email directly or view it on GitHub: https://github.com/mharen/jquery-endless-inputs-plugin/issues/1

Reply to this email directly or view it on GitHub: https://github.com/mharen/jquery-endless-inputs-plugin/issues/1#issuecomment-1728876

mharen commented 13 years ago

ha! I just finished coding it, too! Now we can compare. I think what you do is fork my repo, then commit your change, push it to github, and send me a pull request. Then if it's awesome I merge it in.

I'm about to push my change so you can compare. If yours is better I'll swap it in.