search

mharris717 / ember-cli-pagination

Pagination Addon for Ember CLI
MIT License
272 stars 116 forks source link

total_pages underscore vs dasherized #236

Closed nolman closed 6 years ago

nolman commented 6 years ago

Thanks for writing ember-cli-pagination. I have an issue with how a couple libraries are interacting and thought I would open an issue to start a discussion.

We are using JSONAPI powered by Ember data, ActiveModelSerializers AMS), and Ember CLI Pagination.

Our AMS gem is setup to dasherize all the keys which has worked very well with ember data and everything else thus far, but we are unable to get AMS to leave the total_pages key underscored. Would it be possible to allow for total_pages or total-pages or totalPages or at the very least the ability to configured the expected response? Apologies if this is already supported and I missed it.

broerse commented 6 years ago

Does the paramMapping not work in this case?

https://github.com/mharris717/ember-cli-pagination#using-other-names-for-pageperpagetotal_pages

sdhull commented 6 years ago

I was able to get paramMapping to work. Thank you! You can close this issue.