mharris717 / ember-cli-pagination

Pagination Addon for Ember CLI
MIT License
273 stars 116 forks source link

Fix promise chaining and create shallow copy of ops before passing to store.query #262

Closed synaptiko closed 5 years ago

synaptiko commented 5 years ago

We found two problems in the current code:

  1. promises cannot be chained, there are missing returns
  2. in case ops object passed to store.query is modified in adapter (eg. by deleting a property) it would cause inconsistency

I can split to two separate PRs if you think it would be better or if you are not interested in the second fix.