search

mharris717 / ember-drag-drop

Drag and Drop Addon for Ember CLI
MIT License
205 stars 141 forks source link

Error when using test helper in sortable-objects with handle #107

Open Fl0rianFischer opened 7 years ago

Fl0rianFischer commented 7 years ago

First of all: great plugin, thanks! I'm using Ember 2.0 and ember-drag-drop 0.4.5

I get an error TypeError: Cannot read property 'target' of null when using the drag test helper. It originates in the drag coordinator service but I tracked it down to the dragReady flag not being set in the didInsertElement hook of draggable-object in the tests when using a drag handle.

dgavey commented 7 years ago

Yes I noticed this the other day as well, meant to make an issue to fix it. You can use version 0.4.3 and it won't have this bug. I need to fix this soon. It was introduced with some fixes for mobile.

Fl0rianFischer commented 7 years ago

Thanks so much for you quick answer. You saved my day.

Fl0rianFischer commented 7 years ago

In version 0.4.3 I'm getting this problem

https://github.com/mharris717/ember-drag-drop/issues/98

dgavey commented 7 years ago

Hmm, odd I'm sure it was the same issue.

Fl0rianFischer commented 7 years ago

I'm pretty sure you're right. But when using 0.4.3 the drag test helper seems to be unusable due to another helper not being exposed.