search

mharris717 / ember-drag-drop

Drag and Drop Addon for Ember CLI
MIT License
204 stars 141 forks source link

Upgrade ember-cli-babel 5.x -> 6.x to eliminate deprecation warning #121

Closed jacobq closed 6 years ago

jacobq commented 6 years ago

The current release (0.4.7) triggers an annoying deprecation warning with recent versions of Ember, which would be fixed by upgrading to the latest releases of ember-cli-babel (6.11.x). Please consider upgrading this here.

├─┬ ember-drag-drop@0.4.7
│ └─┬ ember-cli-babel@5.2.4
│   └── ember-cli-version-checker@1.3.1

The deprecation warning looks like this and is described here:

DEPRECATION: An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from:   new NPMDependencyVersionChecker (/path/to/project/node_modules/ember-getowner-polyfill/node_modules/ember-cli-version-checker/src/npm-dependency-version-checker.js:11:33)
nlfurniss commented 6 years ago

Fix is in #124