Missing `ember-native-dom-helpers` dependency for `drag-drop` helper

mharris717 / ember-drag-drop

Drag and Drop Addon for Ember CLI

MIT License

204 stars 141 forks source link

Missing `ember-native-dom-helpers` dependency for `drag-drop` helper #129

Closed panthony closed 5 years ago

panthony commented 6 years ago

I'm using the drag-drop test helpers in my app and it fails with a missing dependency on ember-native-dom-helpers.

I believe we do not really want to list ember-native-dom-helpers in dependencies because we do not want this addon to be packaged in the dist file but maybe this dependency should be listed as required in README.md?

nruth commented 5 years ago

I've also hit this. It allows a test build, but the tests fail at runtime.

Uncaught Error: 
Error: Could not find module `ember-native-dom-helpers` imported from `yourapp/tests/helpers/drag-drop`

Also is the dependency still needed now that https://github.com/cibernox/ember-native-dom-helpers ember-qunit provides similar things? There's a banner warning on the repo.

ondrejsevcik commented 5 years ago

Same here. The PR #151 fixes this issue.

dgavey commented 5 years ago

This has been merged, should be fixed now in 0.7.0 I hope.