mharris717 / ember-drag-drop

Drag and Drop Addon for Ember CLI
MIT License
204 stars 141 forks source link

DragOvering the DraggableObject from one SortableObjects to another not working properly. #212

Open kesavan-ss opened 1 year ago

kesavan-ss commented 1 year ago

Hello, When dragging the object and dragOvering to another list. It was added to the new list even without dropping the item. And not able to shift that item without dropping the currentDragItem. Then I need to drop the current item, drag and dragover the object again to shift the object.

The reason is, const hasSameSortingScope = this. get('currentDragItem.sortingScope ') === emberObject.get('sortingScope'); this.get return undefined in this chain path.

sol: const hasSameSortingScope = this. get('currentDragItem').sortingScope === emberObject.get('sortingScope'); or const hasSameSortingScope = this.currentDragItem.sortingScope === emberObject.sortingScope;

Hopefully, it will not change other behaviors.

Can I create a pull request for this fix?

Thank You:)

wambaloo commented 1 year ago

Hi !

I cannot create pull requests because of rights. But I found the solution. In addon/services/drag-coordinator.js, line 79 you can replace : const hasSameSortingScope = this.get('currentDragItem.sortingScope') === emberObject.get('sortingScope');

by : const hasSameSortingScope = this.get('currentDragItem').get('sortingScope') === emberObject.get('sortingScope');

And it will works :)

dgavey commented 1 year ago

You have to create the PR in your forked copy in order to submit it.