mhart / alpine-node

Minimal Node.js Docker Images built on Alpine Linux
MIT License
2.45k stars 303 forks source link

Consider moving to multi-stage build instead of a single-stage script #116

Open Qix- opened 7 years ago

Qix- commented 7 years ago

Iterative changes to this image are pretty painful I'd imagine 🙃

Now that Docker has multi-stage builds, it'd be pretty trivial to break out the single RUN into multiple layers, with an ultimate FROM alpine again in order to COPY --from all of the artifacts from the source build.

This would allow for proper Docker-ized layers whilst keeping the image size down since all of the intermediate layers of the original build step are omitted from the eventual docker push.

Might be worth considering :)

OmgImAlexis commented 2 years ago

The README has multi-stage builds https://github.com/mhart/alpine-node#example-dockerfile-for-your-own-nodejs-project