search

mhart / aws4

Signs and prepares Node.js requests using AWS Signature Version 4
MIT License
699 stars 175 forks source link

Changes in .travis.yml file #122

Closed nageshlop closed 3 years ago

nageshlop commented 3 years ago

Add support for architecture ppc64le. This is part of the Ubuntu distribution for ppc64le. This helps us simplify testing later when distributions are re-building and re-releasing. The build and test results are available at the below location. https://travis-ci.org/github/nageshlop/aws4

mhart commented 3 years ago

Can you explain a little more how builds on this repository help your distributions?

nageshlop commented 3 years ago

Since this is nodejs, we can use a similar argument, also we want to make sure that this is tested continuously and there are no build or test failures that go undetected on Power as new changes and features get pushed to the repo.

mhart commented 3 years ago

But what software is it used for in the distribution? Why this repository in particular?

Sent from my iPhone

On Nov 24, 2020, at 8:33 AM, Nagesh A T notifications@github.com wrote:

 Since this is nodejs, we can use a similar argument, also we want to make sure that this is tested continuously and there are no build or test failures that go undetected on Power as new changes and features get pushed to the repo.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

mhart commented 3 years ago

I'm going to close this because there's no architecture-specific code in this repository – it's just javascript – it should run on all architectures that Node.js runs on.

If this code doesn't run on a supported architecture, then that's a bug with Node.js and an issue should be filed (and tests added) there. The Node.js repository is here: https://github.com/nodejs/node

seth-priya commented 3 years ago

@mhart appreciate your feedback on this, we understand that this source code may not have any architecture specific dependencies but we have worked with and run automated build and tests on thousands of NPM packages on the Power platform in the past and though as you said, all should ideally work on all architectures but we have seen issues ranging from missing build / runtime dependencies (like chromium, phantomjs to name a few) to dependencies on native libraries, mismatch in node versions and other things that cause upto almost 20% of the packages to fail, that was the context of the PR here.

I do respect your judgement here, but just wanted to clarify anyway and make our standpoint clear, thanks for your kind consideration!

mhart commented 3 years ago

That makes sense for packages with native dependencies – this package has no dependencies at all, let alone native deps.

seth-priya commented 3 years ago

thanks, yes - that makes sense!