mhart / aws4

Signs and prepares Node.js requests using AWS Signature Version 4

MIT License

699 stars 175 forks source link

fix: Fix canonical headers including or not including specific config… #158

Closed Hobart2967 closed 1 month ago

Hobart2967 commented 11 months ago

Fixes: https://github.com/mhart/aws4/issues/157

ryanblock commented 9 months ago

@Hobart2967 seems like a solid fix – any particular reason this PR does not currently include tests?

Hobart2967 commented 9 months ago

No, tbh, not really. Can include them as soon as I have some spare time. Didnt write them because I didnt See there we're some. Im used to have Test Files next to the actual Implementation, and overlooked the test folder while fixing.

mxxk commented 1 month ago

168 includes the same logical changes as this PR, and also adds new tests (as requested). @mhart @ryanblock would you please take a look?

mhart commented 1 month ago

Awesome, thanks for this and apologies for taking so long – I included this in v1.13.1

ryanblock commented 1 month ago

Thanks, @mhart! 👏🏼👏🏼👏🏼