search

mhart / kinesalite

An implementation of Amazon's Kinesis built on LevelDB
MIT License
808 stars 86 forks source link

listShards doesn't respect ExclusiveStartShardId #76

Closed EugeneYushin closed 5 years ago

EugeneYushin commented 6 years ago

listShards.js method returns all shards with no respect to optional ExclusiveStartShardId

This results in manual exclusion of shard ids. Example from Flink codebase: https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java#L457

EugeneYushin commented 6 years ago

PR: https://github.com/mhart/kinesalite/pull/77

tweise commented 5 years ago

@mhart could you please take a look at this? It would be great to get this change. We use Kinesalite for testing and this issue basically makes it difficult to use with legit Kinesis consumer code.

Or are there other maintainers that we could reach out to?

mhart commented 5 years ago

Fixed in v1.15.0

tweise commented 5 years ago

Awesome, thanks!