mhartington / nvim-typescript

Typescript tooling for Neovim
615 stars 76 forks source link

Broken NCM2 integration #217

Closed DonnieWest closed 5 years ago

DonnieWest commented 5 years ago

Warning: I will close the issue without the minimal vimrc and the reproduce ways.

Problems summary

I no longer get completions on ncm2

Expected

Completions should work on ncm2 :)

Where did it break?

git bisect shows it broke on this commit https://github.com/mhartington/nvim-typescript/commit/d93aba1971134c78dce9df349a7711d7ef865b2c

Stack trace of the error

Debug printing information isn't super helpful here

2019-02-15T04:31:58.083Z - error: Error in plugin for function:TSNcm2OnComplete: undefined (file: /home/igneo676/.config/nvim/plugged/nvim-typescript/rplugin/node/nvim_typescript, stack: undefined)
DonnieWest commented 5 years ago

I've not been using this plugin as much lately but noticed it broke. I'll have a chance later to dig into this and hopefully provide a patch :)

Opening mainly to help anyone else who gets stumped :P

DonnieWest commented 5 years ago

Sorry for the noise - older version of Typescript was embedded in the project and it threw me off :page_facing_up: