mhartington / oceanic-next

Oceanic Next theme for neovim
Other
1.13k stars 141 forks source link

XML syntax uses `xmlTagN` rather than `xmlTagName` #114

Closed binyomen closed 1 year ago

binyomen commented 2 years ago

Problems summary

XML syntax is defined using xmlTagN rather than xmlTagName in after/syntax/xml.vim.

Expected

This syntax should use the well-known highlight group xmlTagName.

Environment Information

Provide a minimal vim rc with less than 50 lines (Required!)

" Your minimal init.vim
set runtimepath+=~/path/to/oceanic-next
colorscheme OceanicNext

The reproduce ways from neovim starting

  1. open an XML file
  2. notice that the end tags (</example>) are highlighted using xmlTagN rather than xmlTagName.
jsit commented 1 year ago

@mhartington It strikes me as odd that this color scheme is redefining a syntax match to begin with? It seems like this should be a bug filed against chrisbra/vim-xml-runtime if there is indeed an issue with this syntax. I didn't have this bugfix in my latest pull and I wondered why XML closing tag highlighting was broken.