mhartington / oceanic-next

Oceanic Next theme for neovim
Other
1.14k stars 141 forks source link

Misspelled words are not highlighted #66

Closed jonsmithers closed 6 years ago

jonsmithers commented 6 years ago

Problems summary

With set spell, misspelled words become invisible when I set termguicolors (the red highlight disappears).

Expected

I expect misspelled words to always be visible when spell is set.

Environment Information

notermguicolors termguicolors
vim 8.0 screenshot from 2018-01-31 20-24-24 screenshot from 2018-01-31 20-24-56
neovim 0.2.2 screenshot from 2018-01-31 20-40-59 screenshot from 2018-01-31 20-41-43

As you can see, the issue only exists in vim 8.0 with termguicolors enabled (do you support vim 8?)

minimal vimrc

set runtimepath^=~/.vim/plugged/oceanic-next/
colorscheme OceanicNext
set spell

Reproduction Steps

  1. vim -u minimalvimrc
  2. Type some misspelled words. They are highlighted red.
  3. :set termguicolors
  4. Red highlights on misspelled words.
jonsmithers commented 6 years ago

....well, I can repeat this behavior on the default vim theme, so it clearly has nothing to do with oceaic-next. I guess it's purely a vim 8 thing.

mhartington commented 6 years ago

Hey sorry for the radio silence on my end, I've been traveling for work. Glad to see this is all sorted out

jonsmithers commented 6 years ago

All good, I appreciate the support! Sorry for the misguided issue.