search

mhartington / oceanic-next

Oceanic Next theme for neovim
Other
1.14k stars 141 forks source link

fix: Revert `Normal` color to original base05 code #96

Closed benwoodward closed 3 years ago

benwoodward commented 3 years ago

At https://github.com/mhartington/oceanic-next/commit/08158eec24cd154afd1623686aeb336fad580be7 (the latest branch with the original 'white' value) the color for Normal was base05. https://github.com/mhartington/oceanic-next/blob/08158eec24cd154afd1623686aeb336fad580be7/colors/OceanicNext.vim#L97

In https://github.com/mhartington/oceanic-next/commit/e58e5ee4ecbb5cf8f671f389db55d43dbb592f58 it was changed to s:white: https://github.com/mhartington/oceanic-next/blob/e58e5ee4ecbb5cf8f671f389db55d43dbb592f58/colors/OceanicNext.vim#L97

And in https://github.com/mhartington/oceanic-next/commit/29d694b9f6323c90fb0f3f54239090370caa99fb it wasn't reverted to base05, but base07, which is not full-white, but much brighter than the original base05 color. https://github.com/mhartington/oceanic-next/blob/29d694b9f6323c90fb0f3f54239090370caa99fb/colors/OceanicNext.vim#L97

mhartington commented 3 years ago

Probably going to keep the value that it's at. Mainly because it's a bit easier to read IMO. This can be overwritten though if you'd like in your rc file.