search

mhassan1 / redis-memory-server

Redis Server for testing. The server will allow you to connect your favorite client library to the Redis Server and run parallel integration tests isolated from each other.
MIT License
76 stars 11 forks source link

Windows support #2

Closed shimondoodkin closed 3 years ago

shimondoodkin commented 3 years ago

Windows support

mhassan1 commented 3 years ago

Thank you for the PR! I really appreciate all the work that you put into this, but I feel uncomfortable about distributing an unofficial Redis binary from GitHub. Maybe we can force the consumer of this library to provide the URL to the binary via configuration so that it is clear that they are using it at their own risk. What do you think?

mhassan1 commented 3 years ago

please run yarn and commit the changes to yarn.lock

mhassan1 commented 3 years ago

please add windows to the travis configuration. it should look like this (i think):

language: node_js
node_js:
  - lts/*
  - node
jobs:
  - os: linux
    arch: arm64
  - os: windows
env:
  - YARN_GPG=no
cache:
  directories:
    - .yarn/cache
mhassan1 commented 3 years ago

I'm trying to figure out what this build failure is all about: https://app.travis-ci.com/github/mhassan1/redis-memory-server/jobs/538797915

Then, we will need to get a passing build on Windows. Right now, it's complaining about line endings: https://app.travis-ci.com/github/mhassan1/redis-memory-server/jobs/538797917

mhassan1 commented 3 years ago

Regarding Linux test failures: there may be some interaction between tests running in parallel. Can you please add --runInBand to the coverage script in package.json? Confirmed this fixes the Linux tests: https://app.travis-ci.com/github/mhassan1/redis-memory-server/jobs/539014192

mhassan1 commented 3 years ago

I have resolved all CI issues on a local branch: https://app.travis-ci.com/github/mhassan1/redis-memory-server/builds/238300548

I've created a PR for you to merge the local branch into your windows branch: https://github.com/shimondoodkin/redis-memory-server/pull/1

Once that PR is merged, we should see CI pass here, and then we can merge and release this PR.

shimondoodkin commented 3 years ago

the CRs are from git config auto.crlf true I don't have them

need to set it to false git config auto.crlf false

where is the travis build script?

shimondoodkin commented 3 years ago

I just saw your pull request, I merged it. Thanks