mhausenblas / burry.sh

Cloud Native Infrastructure BackUp & RecoveRY
Apache License 2.0
259 stars 38 forks source link

custom snapshot id does not work #12

Closed juris closed 6 years ago

juris commented 6 years ago

Looks like --snapshot flag makes no effect. No matter what I put there, burry keeps using default snapshot IDs.

/tmp # burry -v
This is burry in version 0.4.0
/tmp # burry --endpoint=zk-1.zk:2181 --isvc=zk --target=local --snapshot="123"
INFO[0000] Selected operation: BACKUP                    func=main
INFO[0000] My config: {InfraService:zk Endpoint:zk-1.zk:2181 StorageTarget:local Creds:{StorageTargetEndpoint: Params:[]}}  func=main
2018/03/27 14:12:32 Connected to 172.17.0.5:2181
2018/03/27 14:12:32 Authenticated: id=171807602279776271, timeout=4000
2018/03/27 14:12:32 Re-submitting `0` credentials after reconnect
INFO[0000] Rewriting root                                func=store
INFO[0000] Operation successfully completed. The snapshot ID is: 1522159952  func=main
/tmp # ls -l
total 4
-rw-r--r--    1 root     root          1039 Mar 27 14:12 1522159952.zip
mhausenblas commented 6 years ago

That's not how snapshot IDs work. The snapshot ID has semantics, it represents the point in time you did the snapshot, in your case it's 1522159952. You can't just overwrite it with an arbitrary value.