search

mhausenblas / burry.sh

Cloud Native Infrastructure BackUp & RecoveRY
Apache License 2.0
259 stars 38 forks source link

S3 improvements: IAM auth and custom bucket name #14

Closed nareshov closed 6 years ago

nareshov commented 6 years ago

The first commit is updates to the vendor/ because a newer minio was required to perform IAM authentication. Which in turn required logrus and so on to be updated.

The second commit is the main reason for this PR. Its own commit message describes the changes made.

mhausenblas commented 6 years ago

Thanks for this @nareshov! Let me have a closer look but skimming through it, looking good.

mool commented 6 years ago

@nareshov awesome! It would be great if you can also add the possibility to set a prefix for uploading the backups to S3. In my case I would like to save backups from different clusters in the same bucket but in a different folder.

mhausenblas commented 6 years ago

@mool maybe best create an issue for it and if @nareshov is up for it, happy to assign it accordingly