search

mhausenblas / burry.sh

Cloud Native Infrastructure BackUp & RecoveRY
Apache License 2.0
259 stars 38 forks source link

Zookeeper harvests information in all nodes #9

Closed geekity closed 7 years ago

geekity commented 7 years ago

Formerly Burry would only harvest ZK data from leaf nodes. As discussed in Issue #7 this was a problem when trying to get a ZK backup for Kafka, which stores its topic shard mapping data in some of the parent nodes. This change lets Burry harvest all the data.

I tested this with the same set up outlined in Issue #7 and it worked fine, but if you have a test suite you would like me to test against, let me know.

Also, sorry for taking ages on getting this change done, the last couple of months turned out to be unexpectedly busy for me. :)

mhausenblas commented 7 years ago

LGTM, thanks a lot @geekity! There is no test suite in place ATM, unfortunately, but PRs are always welcome ;)

Also, if you want to create an AUTHORS.md file and add yourself?