search

mhausenblas / mkdocs-deploy-gh-pages

GitHub Action to deploy an MkDocs site to GitHub Pages
Apache License 2.0
244 stars 90 forks source link

Allow for a custom path and domain at the same time #244

Closed MichaByte closed 1 year ago

MichaByte commented 1 year ago

Resolves #107

Hi! I ran into this issue when trying to combine a docs repo and a code repo into one monorepo. I did a quick fix with action.sh involving moving the check for $CUSTOM_DOMAIN into the if statement that checks for a custom config file path.

I've tested these changes out, and they seem to work great. Here are the use cases I tested:

My testing environment is over at this repo.

Let me know if any changes are in order. Thanks!

MichaByte commented 1 year ago

Just found a bug, so it's not ready to merge quite yet. Fixing it right now

MichaByte commented 1 year ago

I did some mental gymnastics to get here. The issue I'm having is my fault, and the issue I mentioned is unrelated. Sorry!