mhausenblas / reshifter

Kubernetes cluster state management
https://hackernoon.com/introducing-reshifter-for-kubernetes-backup-restore-migration-upgrade-ffaf78da36
Apache License 2.0
294 stars 30 forks source link

distro openshift not detected on openshift 3.6 cluster #16

Open strantalis opened 7 years ago

strantalis commented 7 years ago

What version of Kubernetes (kubectl version) are you using?

Client Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.1+5115d708d7", GitCommit:"fff65cf", GitTreeState:"clean", BuildDate:"2017-08-28T09:00:00Z", GoVersion:"go1.7.6", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.1+5115d708d7", GitCommit:"fff65cf", GitTreeState:"clean", BuildDate:"2017-08-28T09:00:00Z", GoVersion:"go1.7.6", Compiler:"gc", Platform:"linux/amd64"}

What version of etcd (etcdctl --version) are you using?

etcdctl version: 3.2.5 API version: 2

What version of ReShifter are you using (for rcli: rcli version otherwise at the bottom of the app)?

0.3.21

When running rcli explore against a openshift 3.6 cluster I am getting the a distro result as vanilla kubernetes. When I go to perform a backup reshifter doesn't seem to be backing up the openshift.io keys.

etcd version: 3.2.5
API version: v3
Secure: secure etcd, SSL/TLS configure
Distro: Vanilla Kubernetes

Results of rcli stats

Vanilla Kubernetes [keys:742, size:1972284]
OpenShift [keys:73, size:129335]

The only thing that stood out to me was that here it is checking for err != nil when maybe it should be checking err == nil like the getKubeDistrov2 func here. If I am understanding everything correctly.

mhausenblas commented 7 years ago

Thanks for reporting this @strantalis, will have a look at it and try to reproduce it ASAP.