articuluxe
commented
5 years ago Maybe add a defcustom to allow users to control whether files are opened in fundamental-mode? I think that would be more of a pain for me than the slight performance improvement, as I would like the file usable after opening.
On Dec 10, 2018, at 6:06 PM, Nathan Moreau notifications@github.com wrote:
A couple optimizations:
when opening new files, open them in fundamental-mode. some major modes are a bit expensive and worse, some users attach hooks to them that add even more overhead.
reduce a bit allocation rate; appending lists is expensive, especially when the list is not needed.
You can view, comment on, or merge this pull request online at:
https://github.com/mhayashi1120/Emacs-wgrep/pull/54
Commit Summary
Optimize opening of buffers. Reduce allocations. File Changes
M wgrep.el (17) Patch Links:
https://github.com/mhayashi1120/Emacs-wgrep/pull/54.patch https://github.com/mhayashi1120/Emacs-wgrep/pull/54.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
mhayashi1120
A couple optimizations:
when opening new files, open them in fundamental-mode. some major modes are a bit expensive and worse, some users attach hooks to them that add even more overhead.
reduce a bit allocation rate; appending lists is expensive, especially when the list is not needed.