search

mhayashi1120 / Emacs-wgrep

Writable grep buffer and apply the changes to files
GNU General Public License v3.0
612 stars 43 forks source link

Add deadgrep support #58

Closed iquiw closed 1 year ago

iquiw commented 5 years ago

Deadgrep is the fast, beautiful text search that your Emacs deserves. https://github.com/Wilfred/deadgrep

wgrep-deadgrep.el hooks wgrep setup when deadgrep search is finished, which requires deadgrep version 0.7.

I added a test, wgrep-deadgrep-normal in wgrep-subtest.el, which passes. But I failed to make existent wgrep-ag-normal pass in my environment.

DivineDominion commented 2 years ago

@mhayashi1120 This addition would be very welcome :)

PalaceChan commented 1 year ago

wondering if this contribution could still make it in?

mhayashi1120 commented 1 year ago

This repository contains several similar extensions, but I'm not sure if anyone uses them (wgrep-ack.el wgrep-pt.el, etc.), so I'm late wondering what to do.

Since there seem to be many people using deadgrep, I will merge it as it is. If deadgrep or other related packages stop working due to upgrade, please pull-request it.

I'm now reconstructing wgrep new recipe on Melpa. I will also make a recipe for wgrep-deadgrep, so please let me know if it does not work properly.

DivineDominion commented 1 year ago

@mhayashi1120 Thanks! Sounds good, and I'm looking forward to check out the changes