wgrep-ag-normal failing

[sten0]

Hi,

Debian packaging of wgrep has stalled due to this failure, and this is also blocking the update to Ivy 0.13. I'm not sure where the error is occurring, because the "Not a grep result" wrapper. Does this test pass for you using ag.el 0.48?

emacs -batch -Q -l package --eval "(add-to-list 'package-directory-list\
 \"/usr/share/emacs/site-lisp/elpa\")" --eval "(add-to-list 'package-directory-\
list \"/usr/share/emacs/site-lisp/elpa-src\")" -f package-initialize -L . -l wg\
rep-test.el -l wgrep-subtest.el --eval \(ert-run-tests-batch-and-exit\)
Running 7 tests (2020-05-20 21:31:49+0000)
Ag finished
Press C-x C-s when finished or C-c C-k to abort changes.
Test wgrep-ag-normal backtrace:
  signal(error ("Not a grep result"))
  error("Not a grep result")
  (if ov nil (error "Not a grep result"))
  (let ((ov (wgrep-editing-overlay))) (if ov nil (error "Not a grep re
  (save-excursion (let ((ov (wgrep-editing-overlay))) (if ov nil (erro
  wgrep-mark-deletion()
  (lambda (file) (wgrep-test--ag "FOO|HOGE" file) (wgrep-change-to-wgr
  funcall((lambda (file) (wgrep-test--ag "FOO|HOGE" file) (wgrep-chang
  (unwind-protect (funcall body-fn file) (wgrep-test--cleanup-file fil
  (let ((file (concat (make-temp-name "test-data") ".txt"))) (cond ((s
  (let ((default-directory (file-name-as-directory test-directory))) (
  (let ((test-directory (expand-file-name "test-work" default-director
  wgrep-test-fixture("HOGE\nFOO\nBAZ\n" (lambda (file) (wgrep-test--ag
  (progn (wgrep-test-fixture "HOGE\nFOO\nBAZ\n" (function (lambda (fil
  (let ((wgrep-change-readonly-file nil) (wgrep-auto-save-buffer nil))
  (lambda nil (let ((wgrep-change-readonly-file nil) (wgrep-auto-save-
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name wgrep-ag-normal :documentation nil :b
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  eval((ert-run-tests-batch-and-exit))
  command-line-1(("-l" "package" "--eval" "(add-to-list 'package-direc
  command-line()
  normal-top-level()
Test wgrep-ag-normal condition:
    (error "Not a grep result")
   FAILED  1/7  wgrep-ag-normal

Full build log attached here: emacs-wgrep_2.3.2+9.gf0ef9bf-1_amd64-2020-05-20T21:31:26Z.build.txt

[sten0]

Gentle ping :-)

[mhayashi1120]

I know it. I'm not using ag now, so it takes time to fix it. :tired_face:

# I would like to know this package is used by any users.

[sten0]

I know it. I'm not using ag now, so it takes time to fix it.

I understand, and am also overcommitted at the moment. Maybe someone on the Ivy/Counsel team would be willing to help out? @abo-abo ?

I would like to know this package is used by any users.

https://stable.melpa.org/#/wgrep https://stable.melpa.org/#/ag

and

https://melpa.org/#/wgrep https://melpa.org/#/ag

Above the 90th percentile in all cases, so I would say yes :-)