Correctly parses the incoming payload as UTF-8, fixing checks for 👍

mhazy / hapi-github-webhooks

A hapi authentication strategy plugin for validating webhook requests from GitHub.

https://github.com/mhazy/hapi-github-webhooks

MIT License

3 stars 1 forks source link

Correctly parses the incoming payload as UTF-8, fixing checks for 👍 #2

Closed stjohnjohnson closed 8 years ago

stjohnjohnson commented 8 years ago

Ran into issues where PRs contained icons like the one above. Turns out the default encoding of hmac is binary, but we need utf-8 to match what GitHub expects.

https://developer.github.com/webhooks/securing/
http://stackoverflow.com/questions/12195480/node-js-crypto-cannot-create-hmac-on-chars-with-accents

Fixes: https://github.com/screwdriver-cd/screwdriver/issues/246

mhazy commented 8 years ago

@stjohnjohnson Thanks for submitting this, nice catch! I'll get a new release pushed up.

stjohnjohnson commented 8 years ago

Thanks, @mhazy!