mhdzumair / MediaFusion

Universal Stremio Add-On
MIT License
184 stars 27 forks source link

Offcloud links inside zip files dont play #123

Open mhdzumair opened 4 months ago

mhdzumair commented 4 months ago

I have noticed that alot of links pulled by torrentio and mediafusion for offcloud are inside zip files for the entire season however none of these links play. They appear to play fine for both RD and AD. Im not sure if theres an issue with the links that are being scrapped as if its pulling a direct link to the zip file rather than the media file contained within. If i go directly to offcloud and click explore on the zip file the media inside is of course a different link. Is this fixable or is this an offcloud issue?

Originally posted by @MrXT21 in https://github.com/mhdzumair/MediaFusion/discussions/122

mhdzumair commented 4 months ago

I have tested these two series with zipped file (multiple episodes),

image

Both can be played well. So it's not an issue for a torrent to be in a folder. Offcloud can provide the direct link for zipped file.

However, I see a small issue with the implementation function of finding the correct file within zip https://github.com/mhdzumair/MediaFusion/blob/main/streaming_providers/offcloud/client.py#L78-L86, We need to use fuzzy matching as well as file index, and the last option as returning largest video file.

@MrXT21 Each torrent files names and structures are different, so I want the exact torrent detail that you tried with MediaFusion and got into issue.

MrXT21 commented 4 months ago

I have tested these two series with zipped file (multiple episodes),

image

Both can be played well. So it's not an issue for a torrent to be in a folder. Offcloud can provide the direct link for zipped file.

However, I see a small issue with the implementation function of finding the correct file within zip https://github.com/mhdzumair/MediaFusion/blob/main/streaming_providers/offcloud/client.py#L78-L86, We need to use fuzzy matching as well as file index, and the last option as returning largest video file.

@MrXT21 Each torrent files names and structures are different, so I want the exact torrent detail that you tried with MediaFusion and got into issue.

Screenshot_

Screenshot 2024

ragmehos commented 4 months ago

@mhdzumair Maybe this is the same stremio bug with the name containing "[" as a problem?

mhdzumair commented 4 months ago

Not having free quota to test this, we need to test with following stream specifically.

ragmehos commented 4 months ago

I can give it a try, @MrXT21 which device are you trying this on? I wonder if this is the same issue as https://github.com/Stremio/stremio-bugs/issues/665

mhdzumair commented 4 months ago

which device are you trying this on?

The screenshot is from android 😃

mhdzumair commented 4 months ago

I wonder if this is the same issue as https://github.com/Stremio/stremio-bugs/issues/665

I have provided a sample magnet link on that issue. you can directly test it whether the link is containing those characters if so, we need to implement the same functionality in the seedr like renaming the files before creating the link.