Closed MunifTanjim closed 6 days ago
[!CAUTION]
Review failed
The pull request is closed.
The pull request introduces updates across multiple files to support a new streaming provider, "StremThru." Key changes include the addition of a new service option and an associated URL field in the StreamingProvider
class within db/schemas.py
, modifications to the HTML configuration for user input, and enhancements to JavaScript logic for handling service URLs. New utility functions and a client class for the StremThru service are created, ensuring proper interaction with the streaming API. Additionally, CSS styles are adjusted to accommodate the new input fields.
File | Change Summary |
---|---|
db/schemas.py |
Added field: url , added service literal "stremthru" in StreamingProvider . |
resources/css/styles.css |
Updated selector for margin-top to include #service_url_section . |
resources/html/configure.html |
Added option for "StremThru (Interface)" and a new section for "Service URL" input. |
resources/js/config_script.js |
Introduced constant servicesRequiringUrl for handling visibility of service_url_section ; modified validation logic for URL input. |
streaming_providers/mapper.py |
Added mappings for "stremthru" in various function dictionaries for caching and fetching data. |
streaming_providers/stremthru/client.py |
Introduced StremThru class with methods for API interaction and error handling. |
streaming_providers/stremthru/utils.py |
Added utility functions for interacting with StremThru, including URL retrieval and torrent management. |
utils/const.py |
Updated STREAMING_SERVICE_REQUIREMENTS to include "stremthru" with required parameters. |
url
and a service option "stremthru"
to the StreamingProvider
class, which is directly related to the changes in the resources/html/configure.html
and resources/js/config_script.js
files that introduce a new section for entering a "Service URL" and handling the display of the service URL input based on the selected provider.url
field in the StreamingProvider
class, indicating a direct relationship in terms of functionality.db/schemas.py
file regarding the UserData
class and the introduction of the contribution_streams
field relate to the main PR's modifications to the StreamingProvider
class, as both involve user data handling and configuration options.StreamingProvider
class, as both focus on improving the configuration and validation processes for streaming services.hacktoberfest-accepted
🐇 In the meadow, hops a little hare,
With fields of code, we craft with care.
StremThru's here, with URLs to share,
New options bloom, like springtime air.
So let us code, with joy and glee,
For every change, a new journey! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Nice, lmk once you're done with the changes.
is it ready for review? Please add validate credential function as well.
Not ready yet. I'm on vacation, will be back on 16th Nov and finish it after that.
No worries, take your time & enjoy the vacation
Address the above suggestion which contain :+1:
StremThru: https://github.com/MunifTanjim/stremthru
Example Config for StremThru:
Run by following: https://github.com/MunifTanjim/stremthru?tab=readme-ov-file#usage
Summary by CodeRabbit
Summary by CodeRabbit
Release Notes
New Features
UI/UX Improvements
Bug Fixes