search

mhe / pynrrd

Simple pure-python module for reading and writing nrrd files.
https://pynrrd.readthedocs.io/
MIT License
116 stars 51 forks source link

Fix issue with loading large files #101

Closed addisonElliott closed 5 years ago

addisonElliott commented 5 years ago

This is the error message that would popup before this fix:

Size of the data does not equal to the product of all dimensions

Problem was that multiplying the dimensions together was overflowing the 32-bit result for larger than 4GB files.

Fixes #100

codecov-io commented 5 years ago

Codecov Report

Merging #101 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files           6        6           
  Lines         374      374           
  Branches      119      119           
=======================================
  Hits          372      372           
  Misses          1        1           
  Partials        1        1
Impacted Files Coverage Δ
nrrd/reader.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 96dd875...b9c58c4. Read the comment docs.