search

mhe / pynrrd

Simple pure-python module for reading and writing nrrd files.
https://pynrrd.readthedocs.io/
MIT License
116 stars 51 forks source link

'measurement frame' field must be a double matrix, fixes #76 #77

Closed ihnorton closed 5 years ago

ihnorton commented 5 years ago

@tashrifbillah

addisonElliott commented 5 years ago

PR looks good to me, just need to resolve the tests.

tashrifbillah commented 5 years ago

numpy.set_printoptions() clearly has floatmode argument. https://docs.scipy.org/doc/numpy-1.14.0/reference/generated/numpy.set_printoptions.html

The only other reason I can think of is the numpy in travis-ci is outdated.

codecov-io commented 5 years ago

Codecov Report

Merging #77 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files           6        6           
  Lines         362      362           
  Branches      117      117           
=======================================
  Hits          319      319           
  Misses         21       21           
  Partials       22       22
Impacted Files Coverage Δ
nrrd/reader.py 83.73% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b084ed...d32c400. Read the comment docs.

ihnorton commented 5 years ago

Updated to fix (realized set_printoptions wasn't doing anything anyway, because any assertion failures go through whatever nose uses to print).

tashrifbillah commented 5 years ago

@ihnorton , when printing the bvecs, should I use: np.set_printoptions(suppress= True, floatmode= 'maxprec') or just set precision= 17 ?