search

mhe / pynrrd

Simple pure-python module for reading and writing nrrd files.
https://pynrrd.readthedocs.io/
MIT License
116 stars 51 forks source link

Document that header object given to nrrd.write will be updated with auto generated fields #86

Closed addisonElliott closed 5 years ago

addisonElliott commented 5 years ago

Includes some minor fixes to the docs that were causing problems.

addisonElliott commented 5 years ago

@simeks Mind reviewing this when you get a chance?

I'm going to go ahead and merge yours now.

codecov-io commented 5 years ago

Codecov Report

Merging #86 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files           6        6           
  Lines         361      361           
  Branches      116      116           
=======================================
  Hits          358      358           
  Misses          1        1           
  Partials        2        2
Impacted Files Coverage Δ
nrrd/writer.py 97.43% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 07d2227...478199a. Read the comment docs.

simeks commented 5 years ago

@simeks Mind reviewing this when you get a chance?

Looks good! Makes more sense now when you actually see it in the docs :+1:.