Closed timwoj closed 2 years ago
Thanks. The dead code warning was mostly a none issue, but the other two were valid. I'll try and set Coverity up for libkqueue directly. There's probably quite a few other issues given that I'm not sure libkqueue has ever been run through a static analysis tool before.
I recently updated the Zeek project to use libkqueue 2.6.0. Part of our CI pipeline is a pass through Coverity's Scan project. I normally disable checking third-party code but I apparently hadn't yet for libkqueue, and the 2.6.0 update had some new findings in it. They may all be false-positives, but I figured I should report them anyways. This is about the best I can do for reporting these as I'd have to add someone to the project on the Scan site to see the full details. Note all of these findings are on a Linux build.
Missing unlock in
src/common/kqueue.c
:Dead code in
src/linux/user.c
:Double unlock in
src/posix/proc.c
: