don't redefine HIDDEN/VISIBLE macros on MinGW

mheily / libkqueue

kqueue(2) compatibility library

Other

236 stars 77 forks source link

don't redefine HIDDEN/VISIBLE macros on MinGW #142

Closed neheb closed 2 years ago

neheb commented 2 years ago

Signed-off-by: Rosen Penev rosenp@gmail.com

arr2036 commented 2 years ago

It seems like you're invested in getting MinGW building cleanly... As I've said to others submitting patches for Windows, it'd be very helpful if you could add an example of your environment to GitHub actions, then we can ensure that things don't break between releases.

neheb commented 2 years ago

I'd have to look into getting an MSYS2 CI setup. I've never done such a thing. I assume MSVC still has redefinition issues.

I see libkqueue also has solaris support. Wonder if solaris has C11 atomics...