search

mheinzinger / SeqVec

Modelling the Language of Life - Deep Learning Protein Sequences
MIT License
71 stars 26 forks source link

2 errors/ typos in readme #1

Closed flomock closed 5 years ago

flomock commented 5 years ago

in the first line it should be: from allennlp.commands.elmo import ElmoEmbedder instead of your version without the d

and you give the ElmoEmbedder the parameter in the wrong order, it should be: seqvec = ElmoEmbedder(options,weights,cuda_device=0)

would be nice if you fix this

sacdallago commented 5 years ago

Thanks for the heads up, on it

mheinzinger commented 5 years ago

Thanks for notifying! Fixed.