mhelvens / latex-pkgloader

a LaTeX package for managing the options and loading order of other packages
LaTeX Project Public License v1.3c
33 stars 3 forks source link

Add settings for microtype #21

Closed koppor closed 6 years ago

koppor commented 6 years ago

I understand that your aim is high quality documentation. My aim is to get this thing usable in non-trivial cases. One of the driving force for this project is lack of time though.

Michiel Helvensteijn notifications@github.com schrieb am Do., 5. Apr. 2018, 18:51:

@mhelvens commented on this pull request.

In pkgloader-recommended.sty https://github.com/mhelvens/latex-pkgloader/pull/21#discussion_r179529922 :

@@ -243,3 +243,20 @@ % \end{macrocode} % %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% + +%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% +% +% Extracted https://tex.stackexchange.com/a/162436/9075, +% where the author of microtype recommends loading settings. +% Furthermore, use the hints from https://texdoc.org/pkg/microtype -> "Hints and Caveats" +% +% \begin{macrocode} +\Load {fontspec} before {microtype}

  • if {fontspec}
  • because {the author recommends without any further reasoning}

I don't think that's enough to warrant inclusion in the default rules.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mhelvens/latex-pkgloader/pull/21#pullrequestreview-109791818, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTaflDHzEV9SWBp3SU5b5-NGE2r7tuvks5tlkuKgaJpZM4THypx .

mhelvens commented 6 years ago

because {the author recommends without any further reasoning}

I don't think that's enough to warrant inclusion in the default rules.

I understand that your aim is high quality documentation. My aim is to get this thing usable in non-trivial cases. One of the driving force for this project is lack of time though.

I wasn't suggesting that your documentation was bad. I was saying that if the given reason was really accurate (recommended without any further reasoning), then it probably shouldn't be imposed on all users of pkgloader.

And as it turns out, that answer was dated anyway. The microtype documentation does not recommend a loading order between microtype and fontspec because the loading order no longer matters. See page 43, the text above line 356.

I greatly appreciate that you want to help make this package better. But adding bad or unnecessary rules is counterproductive. That's the main reason I insist on good justifications for every rule.

Note that you can still use your own set of rules to augment the default ones provided in the package. Check out the docs to learn how. Though if you discover a rule that's universally useful (and can explain why), do keep those PRs coming!

koppor commented 6 years ago

I think either rules are universally applicable or not useful at all. I appreciate your reviews.

mhelvens commented 6 years ago

Thanks for the fix. I'll wait with this one until the other PR is also ready, so I can do them in one batch.

koppor commented 6 years ago

There shouldn't be conflicts, so you could just merge. In case, there'll be conflicts, I'll resolve them in https://github.com/mhelvens/latex-pkgloader/pull/22.