search

mhemesath / r2d3

Raphael Rendered, Data Driven Documents
MIT License
546 stars 133 forks source link

Fix issue #49 #115

Closed marciocaraballo closed 11 years ago

marciocaraballo commented 11 years ago

Addressing issue #91

I built an example on a repository using the fixed version of r2d3 for this issue, since I'm having some problems with jsffidle and jsbin.

Example :

https://github.com/marciocaraballo/r2d3example/

if (before && r2D3Element.domNode.tagName !== 'g') { r2D3Element.raphaelNode.insertBefore(before.raphaelNode); }

Adding that check in insertBefore solves the problem, since new ticks add 'g' elements, and they have raphaelNode = null.

mhemesath commented 11 years ago

Nice, I'll take a close look at this in the next day. Thanks!

mhemesath commented 11 years ago

This looks good, a previous merged created a conflict though. Do you mind rebasing then I can merge this through. Thanks!!

marciocaraballo commented 11 years ago

Rebase done, and r2d3.js was rebuilt using make.

mhemesath commented 11 years ago

Thanks !