search

mher / flower

Real-time monitor and web admin for Celery distributed task queue
https://flower.readthedocs.io
Other
6.48k stars 1.09k forks source link

Favicon not assigned and icon in navbar does not work #1338

Closed joesolly closed 11 months ago

joesolly commented 12 months ago

Describe the bug There is no favicon defined in the <head> block so when flower is served with a url_prefix, the favicon does not display properly. Also, because the navbar is a Tornado Template rather than an {% import, it has its own namespacing and does not inherit the static_url behavior, which leaves the icon pointing to /favicon.ico

To Reproduce Steps to reproduce the behavior (favicon):

  1. look in <head> block and see no explicit mention of favicon.ico This becomes an issue when flower is served from a url_prefix as browsers will default to /favicon.ico

Steps to reproduce the behavior (navbar):

  1. start flower with a url_prefix
  2. see that the icon in the navbar does not point to /$urlprefix/favicon.ico but instead to /favicon.ico

Expected behavior favicon.ico is explicitly located in the <head> block and the navbar image works when using url_prefix

Screenshots Screenshot 2023-11-20 at 4 29 34 PM Screenshot 2023-11-20 at 4 29 43 PM Screenshot 2023-11-20 at 4 30 02 PM

onyx-flame commented 11 months ago

This issue should be fixed in v2.0.1 Which version are you using?

joesolly commented 11 months ago

This issue should be fixed in v2.0.1 Which version are you using?

I'm still on 2.0.0, thanks for the heads up

joesolly commented 11 months ago

I tested on 2.0.1 and it's working