search

mherkazandjian / fastgrab

Python package for taking super-fast screenshots
GNU General Public License v3.0
60 stars 4 forks source link

your lib seems sketchy #6

Open movie99 opened 4 years ago

movie99 commented 4 years ago

when running your code it was downloading vurtualenv and other unnecessary packages.

Jah-On commented 4 years ago

The code is yours to look at, I didn't see any virtualenv references.

mherkazandjian commented 1 year ago

i think the virtualenv installation is triggered by this https://github.com/mherkazandjian/fastgrab/blob/master/Pipfile#L9 that is needed for development. virtualenv is not used anywhere in the code though, it is basically used by pipenv in case you want to develop the package itself. (sorry for the late reply, just cleaning up the issues)

Arcitec commented 5 months ago

The code is short enough that I read through it in 10 minutes. It's completely clean.

Thanks for creating this fast little library!