search

mherkender / lua.js

An ECMAscript framework to compile and run Lua code, allowing Lua to run in a browser or in Flash
http://blog.brokenfunction.com/
600 stars 73 forks source link

Couple of fixes (node 10 & closure compiler), after 5 years of inactivity #44

Closed nomaed closed 5 years ago

nomaed commented 5 years ago

Hi,

I found this repo while reading up about Lua and found it interesting. I cloned it and tried building but there were two issues I came across:

  1. It no longer builds with the modern Node v10+
  2. Closure Compiler latest version URL changed and also the JAR filename itself in it

While I know that this is a dormant project and there's a chance that nobody will look at it, I still wanted to update the project with a couple of fixes I made, to be able to run this in late 2018 too.

There are 2 pull requests:

I merged these two in my fork (https://github.com/nomaed/lua.js/tree/master) in case anyone wants to build it but these PRs won't be merged in here.

nomaed commented 5 years ago

Thanks for merging these in, @mherkender!