mherrmann / fbs-tutorial

Tutorial for creating Python/Qt GUIs with fbs
https://build-system.fman.io
GNU General Public License v3.0
1.95k stars 161 forks source link

Update Readme for windows installer/code signing #47

Closed meramsey closed 3 years ago

meramsey commented 4 years ago

Updated Readme to include some useful information for Windows installer and code signing stuff. This can be pretty confusing to do if not done before and will save future readers time and confusion digging up how to do these steps.

I also highly recommend updating the manual > https://build-system.fman.io/manual/#codesigning-windows with the information regarding the signtool.exe requirement as I was not aware this was not installed by default or in the system path and needed to be added. I spent way too much time on it and figured this would save someone else new the same unecessary frustrating experience.

Feel free to reword or format if desired. If you would like screenshots of any of the steps let me know can provide them.

mherrmann commented 3 years ago

Thank you. I don't think it makes much sense to add these steps to fbs's tutorial. However, like you suggested, I've updated the Manual to link to your instructions in the Windows code signing section.