search

mherrmann / helium

Lighter web automation with Python
MIT License
4.79k stars 364 forks source link

support apple cpu and upgrade driver #83

Open 0ldm0s opened 2 years ago

0ldm0s commented 2 years ago

support apple cpu and upgrade driver to new version. chromedriver: 101.0.4951.41 geckodriver: 0.31.0

and do some beautify code.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

mherrmann commented 2 years ago

Thank you, I appreciate it. But you've changed tabs to spaces everywhere. I can't merge the PR this way. Please see my guidelines: https://gist.github.com/mherrmann/5ce21814789152c17abd91c0b3eaadca

Thanks!

tbp105 commented 10 months ago

Main now pulls the binaries as needed so I think this MR isn't needed anymore.