mhetrick / hetrickcv

VCV Rack Modules by Michael Hetrick
Creative Commons Zero v1.0 Universal
155 stars 13 forks source link

Loading Phasor -> Waveforms crashes VCV #30

Closed dandante closed 1 year ago

dandante commented 1 year ago

Hi,

Just heard about the new Phasor modules today and I'm excited to try them out.

I notice that loading Phasor -> Waveforms immediately crashes VCV Rack 2.3.0 (default x86 build) on my M2 Macbook Pro running macOS 13.4.1. None of the other Phasor modules do this.

Not sure if this is an issue with the module or with VCV Rack but I thought I'd report it here. Let me know if I can provide any more information.

Here is the relevant portion of log.txt:

[6.911 info src/network.cpp:150 requestJson] Requesting JSON GET https://api.vcvrack.com/modules
[6.921 info src/app/Browser.cpp:200 createPreview] Creating module widget HetrickCV Waveshaper
[6.921 info src/window/Svg.cpp:28 loadFile] Loaded SVG /Users/zz/Documents/Rack2/plugins/HetrickCV/res/Waveshape.svg
[12.200 info src/app/Browser.cpp:88 chooseModel] Creating module HetrickCV Phasor to Waveforms
[12.201 info src/app/Browser.cpp:92 chooseModel] Creating module widget HetrickCV Phasor to Waveforms
[15.009 info src/patch.cpp:211 saveAutosave] Saving autosave /Users/zz/Documents/Rack2/autosave/patch.json
[15.014 info src/settings.cpp:491 save] Saving settings /Users/zz/Documents/Rack2/settings.json
[21.823 fatal adapters/standalone.cpp:49 fatalSignalHandler] Fatal signal 6. Stack trace:
25: Rack(fatalSignalHandler(int)+27)
24: libsystem_platform.dylib(_sigtramp+29)
23: ???(0x0+0)
22: libsystem_c.dylib(abort+123)
21: libsystem_malloc.dylib(malloc_vreport+888)
20: libsystem_malloc.dylib(malloc_zone_error+183)
19: libsystem_malloc.dylib(nanov2_guard_corruption_detected+34)
18: libsystem_malloc.dylib(nanov2_allocate_outlined+385)
17: libsystem_malloc.dylib(nanov2_malloc_zero_on_alloc+534)
16: libc++abi.dylib(operator new(unsigned long)+26)
15: libc++.1.dylib(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>::__init_copy_ctor_external(char const*, unsigned long)+59)
14: libRack.dylib(rack::system::join(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&)+879)
13: libRack.dylib(rack::asset::system(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>)+24)
12: libRack.dylib(rack::app::RailWidget::step()+249)
11: libRack.dylib(rack::widget::Widget::step()+185)
10: libRack.dylib(rack::widget::Widget::step()+185)
9: libRack.dylib(rack::widget::Widget::step()+185)
8: libRack.dylib(rack::widget::Widget::step()+185)
7: libRack.dylib(rack::ui::ScrollWidget::step()+19)
6: libRack.dylib(rack::app::RackScrollWidget::step()+843)
5: libRack.dylib(rack::widget::Widget::step()+185)
4: libRack.dylib(rack::app::Scene::step()+494)
3: libRack.dylib(rack::window::Window::step()+1573)
2: libRack.dylib(rack::window::Window::run()+40)
1: Rack(main+4543)
0: dyld(start+1903)

I notice that after the crash if I click "Reopen" and then tell VCV that I do NOT want to start over, then VCV will start with the Phasor -> Waveforms module loaded. But then a crash happens again when I try to connect the Saw output of the VCV Fundamental LFO to the Phasor In of Phasor -> Waveforms.

Thanks!

mhetrick commented 1 year ago

Thanks! This is fixed in 2.3.1. Please download the latest build from this repo. It will be available on the VCV Library soon.