When a file doesn't exist, jasmine-node exits with 0 status code

mhevery / jasmine-node

Integration of Jasmine Spec framework with Node.js

MIT License

1.52k stars 292 forks source link

When a file doesn't exist, jasmine-node exits with 0 status code #379

Open ppissanetzky opened 9 years ago

ppissanetzky commented 9 years ago

$ jasmine-node --version && jasmine-node --captureExceptions foo; echo $?
1.14.3
File: .../foo is missing.
0

gagern commented 8 years ago

The same holds when a spec file exists but has broken syntax.

$ echo '"' > test-spec.js && jasmine-node test-spec.js; echo $?
Exception loading: /Users/gagern/src/up/jasmine-node/test-spec.js
[SyntaxError: Unexpected token ILLEGAL]
0

Observed for 1.14.3 and 2.0.0-beta4.

Krijger commented 8 years ago

This issue undermines the use of jasmine-node in Docker test containers. I came across this while writing tests with https://github.com/stackwork/stackwork for an API project.

gagern commented 8 years ago

@Krijger In https://github.com/Khan/KaTeX/pull/387 I found out that jasmine itself supports node. So to me the jasmine-node package appears deprecated.

If that is the case, a statement to that effect in a prominent place in the README might help. Perhaps even a new release with a new major version which either forwards everything to jasmine itself, or informs users that this package is no longer needed.