v1.14/v1.15 includes a breaking change in a minor version.

[ljharb]

v1.14 works on node < 4; v1.15 does not. This is a major change.

Please revert and publish a v1.15 patch; and if you'd like to drop node < 4, please republish as a v2.

See https://travis-ci.org/es-shims/es5-shim/jobs/423131852 for an example.

EDIT by @brodybits: the breaking change is in 7ad50c84f46fd8b67ac0695c1c1f9b940aa11c94:

--- a/package.json
+++ b/package.json
@@ -25,7 +25,7 @@
   "dependencies": {
     "coffee-script": ">=1.0.1",
     "jasmine-reporters": "~1.0.0",
-    "jasmine-growl-reporter": "~0.0.2",
+    "jasmine-growl-reporter": "~1.0.1",
     "requirejs": ">=0.27.1",
     "walkdir": ">= 0.0.1",
     "underscore": ">= 1.3.1",

See below and https://github.com/es-shims/es5-shim/commit/5a27afb050b333f6b0f6b8f7e93dbf4a66c4a7d7 for explanation.

Second possibly breaking change was the following (already fixed now):

   "dependencies": {
-    "coffee-script": ">=1.0.1",
+    "coffeescript": ">=1.0.1",
     "jasmine-reporters": "~1.0.0"

[ljharb]

k turns out it’s not in this project, but a dep: https://travis-ci.org/es-shims/es5-shim/builds/423137988

I’ll debug more later today; either the dep needs to get fixed or jasmine-node needs to pin it, whichever it is.

[brodycj]

Thanks for the update. From https://github.com/mhevery/jasmine-node/compare/1.14.x...master the only breaking change I can see is in package.json:

   "dependencies": {
-    "coffee-script": ">=1.0.1",
+    "coffeescript": ">=1.0.1",
     "jasmine-reporters": "~1.0.0"

which has the same effect as using coffeescript@2 (until they publish another major release). Now labeled as a bug, hope to publish an update sometime next week.

As a side point I would rather fix this one thing than revert the whole change in 7aa3b531edef2aa870cf88fb61251ccab0c63351. Less messy in the history (IMHO). Another side point is that there is already a "v2" branch (https://github.com/mhevery/jasmine-node/tree/Jasmine2.0) that seems to both have new features and be outdated.

[brodycj]

I just published pushed version 1.5.1 which uses coffeescript@1 in order to remove possibly breaking change from version 1. (My bad: I discovered that I did not update version in package.json, missed the npm publish error message. I just removed the 1.5.1 tag; update is now published as 1.6.0 as described below.)

Some general comments:

I would recommend transitioning from jasmine-node to jasmine whenever possible. I took over maintenance (not ownership) of this project for the sake of projects that are not yet ready to transition for some reason. Motivation for me is cordova-js (we would need to change the Cordova JavaScript, which is not wanted in a minor release). I am guessing es5-shim would have a similar motivation.

FYI both 1.5.0 and 1.5.1 seem to work on Node.js 4. So I suspect there is something really strange going on in es5-shim. Maybe with dependencies, maybe something else. But I am really happy that the reported observations led to the discovery of unwanted coffeescript upgrade in dependencies.

Another side point I discovered is that this project does not have anything like Travis CI enabled. Considering that this project is really in a "maintenance mode" I will probably leave this part at a very low priority.

[brodycj]

I just published version 1.6.0 which uses coffeescript@1, fixes some other dependencies to avoid major package updates, and adds a note that this package is in maintenance mode. Best of luck to @ljharb in solving the problem with es5-shim for good. Closing now.

[ljharb]

Thanks, I appreciate the effort - I'll post here if i think there's anything further for jasmine-node to do.

[ljharb]

Found the source: https://github.com/tj/node-growl/issues/79 via jasmine-growl-reporter (https://github.com/AlphaHydrae/jasmine-growl-reporter/issues/3)

[ljharb]

One possible change here would be to drop the jasmine-growl-reporter dep from ~1 back to ~0.2 - that seems to have been the trigger :-/

[brodycj]

@ljharb I would definitely see the following change in 7ad50c84f46fd8b67ac0695c1c1f9b940aa11c94 as a breaking change:

--- a/package.json
+++ b/package.json
@@ -25,7 +25,7 @@
   "dependencies": {
     "coffee-script": ">=1.0.1",
     "jasmine-reporters": "~1.0.0",
-    "jasmine-growl-reporter": "~0.0.2",
+    "jasmine-growl-reporter": "~1.0.1",
     "requirejs": ">=0.27.1",
     "walkdir": ">= 0.0.1",
     "underscore": ">= 1.3.1",

I wish you would have reported this observation in a new, separate issue. Considering that you have already referenced this issue from some other places, I am am reopening it with updated title description to reflect the new information. I will try to resolve this one along with #435 (use tilde instead of carrot) in a patch today.

And yes, you can definitely blame me for the breaking changes here😒

[ljharb]

Thanks, since it was the same root problem I figured I'd post it here; i'm happy to file a new one if you like.

[brodycj]

Let's keep it here. You were right: evidence of the root problem was already given in the description.

I think part of the confusion was that the breaking change in 7ad50c8 was in 1.14.6, which was not marked so clearly, and caused the trouble in https://github.com/es-shims/es5-shim/commit/37e7f3ebca4c42296adf9e753c3a956dd8c84fae.

[brodycj]

I would also like to see a quick, easy-to-read description of npm semver etiquette that we can point people to, to help avoid this kind of issue in the future. I just raised the request in semver/semver#461.

[brodycj]

node lib/jasmine-node/cli.js --growl spec mostly passes on Node.js 4.0, 0.12, and 0.10 if I checkout version 1.14.5.

It does not work on Node.js 4.0 0.12 if I use version 1.16.0. Patch fix should be coming today.

[brodycj]

Should be fixed in recently published version 1.16.2.

@ljharb can you explain if there is any reason to continue supporting v1.x with support for Node.js pre-6.0? Is Node.js pre-4.0/pre-6.0 needed to test JavaScript shim? If so, would you guys be open to using something like Duktape to test shim of newer JavaScript versions?

It would be ideal if we can drop and abandon support for Node.js 6.0 (in new major release).

[ljharb]

The shims need to be tested in older engines; duktape definitely wouldn't be feasible. It's totally fine if you want to drop support in v2; if it ever stops working, i'd have to migrate my tests off jasmine (i've already begun migrating all my packages that use mocha and jest off of them, for this reason). I'd rather not do that in this particular repo, though :-)

[ljharb]

Thanks; the issue is indeed fixed https://travis-ci.org/es-shims/es5-shim/builds/424538191

Much obliged!!

[brodycj]

Thanks for the confirmation. I've been thinking if es5-shim is one of the most important active users of this library then it may not make sense to drop Node.js pre-4.0 anytime soon.