Safaribook download video extension not working

[rupeshvins]

hi Safaribook download video extension not working,

[mhewedy]

Fix is in this branch https://github.com/mhewedy/SBO-video-extension/tree/New_UI, but I rolled it out after deployment cause safari rolled back the new changes.

[iandjx]

Using the New_UI branch at the moment. Extension sometimes doesn't work. Works on the following https://www.safaribooksonline.com/videos/kotlin-for-beginners/9781788625944 https://www.safaribooksonline.com/videos/learning-path-web/9781788479851

Doesnt work on the following https://www.safaribooksonline.com/learning-paths/learning-path-kotlin/9781788994675/ https://www.safaribooksonline.com/videos/professional-python-web/200000006A0402

[mhewedy]

I do not think this is a new UI related issue.

Check this line: https://github.com/mhewedy/SBO-video-extension/blob/New_UI/core/crawlerService.js#L47

[iandjx]

I see. Will these URLs be supported in the near future? Maybe another let jsSrc statement?

[iandjx]

As a workaround, using Video DownloadHelper chrome extension does the job, albeit not as efficient as this extension

[rupeshvins]

Use idm on Firefox, and see the change

On Saturday, June 16, 2018, Ian Christopher B. de Jesus < notifications@github.com> wrote:

Using the New_UI branch at the moment. Extension sometimes doesn't work. Works on the following https://www.safaribooksonline.com/videos/kotlin-for- beginners/9781788625944 https://www.safaribooksonline.com/videos/learning-path-web/9781788479851

Doesnt work on the following https://www.safaribooksonline.com/learning-paths/learning- path-kotlin/9781788994675/ https://www.safaribooksonline.com/videos/professional- python-web/200000006A0402

[image: screenshot_1] https://user-images.githubusercontent.com/3683356/41498174-8716ad1c-71a1-11e8-8c96-3a7b460b2f4f.png [image: screenshot_2] https://user-images.githubusercontent.com/3683356/41498175-876970a6-71a1-11e8-8adc-7ae94b21d1c1.png [image: screenshot_3] https://user-images.githubusercontent.com/3683356/41498176-87b01204-71a1-11e8-8966-8c85b8673ce4.png [image: screenshot_4] https://user-images.githubusercontent.com/3683356/41498177-87e4b5fe-71a1-11e8-90b3-8c748b026031.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mhewedy/SBO-video-extension/issues/53#issuecomment-397805230, or mute the thread https://github.com/notifications/unsubscribe-auth/AHKtqkRgVBfmYZM6TKBCZYPXJBS1IUe2ks5t9OgbgaJpZM4Upa_y .

[mhewedy]

Is the issue still exists?

[nabilazri]

Hey yeah, the issue still exists, it seems that the extension doesn't work properly :/

[rupeshvins]

@my end no issue.

On Thu, Sep 6, 2018 at 5:43 AM designer91 notifications@github.com wrote:

Hey yeah, the issue still exists, it seems that the extension doesn't work properly :/

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mhewedy/SBO-video-extension/issues/53#issuecomment-418921484, or mute the thread https://github.com/notifications/unsubscribe-auth/AHKtqkALpC4VyOQntQi13NM0qx9RzM27ks5uYGjCgaJpZM4Upa_y .

[mhewedy]

@rupeshvins thanks foe letting me know.

[rupeshvins]

Hi today I face a problem, didn't download video from safari( already login) didn't download from all Learning Path related videos. but others like strata via search in safaribooks able to download. plz fix the issue mail me

Thanks a lot

On Thu, Sep 6, 2018 at 5:43 AM designer91 notifications@github.com wrote:

Hey yeah, the issue still exists, it seems that the extension doesn't work properly :/

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mhewedy/SBO-video-extension/issues/53#issuecomment-418921484, or mute the thread https://github.com/notifications/unsubscribe-auth/AHKtqkALpC4VyOQntQi13NM0qx9RzM27ks5uYGjCgaJpZM4Upa_y .

[mhewedy]

@rupeshvins Learning Path is not supported.