Download button missing in Courses (techbus)

mhewedy / SBO-video-extension

Safari Books Online Video Downloder Extension to Google Chrome

https://chrome.google.com/webstore/detail/safari-books-online-video/ihgjlggckknakenjhgmfgaoalflhfihl

109 stars 32 forks source link

Download button missing in Courses (techbus) #97

Open ravikiran-sk opened 5 years ago

ravikiran-sk commented 5 years ago

Hi,

I'm not able to see the download button in the below courses. Please help !

https://learning.oreilly.com/videos/agile-for-everybody/9781492051640 https://learning.oreilly.com/videos/77-728-expert-excel/9781838641290 https://learning.oreilly.com/videos/77-728-complete-techniques/9781838648084

And also I have one more question, Is the extension not working anymore to download courses from techbus site? From Last week I'm not able to see the download button in the techbus site for any of the courses.

Appreciate you help Thanks in Advance

mhewedy commented 5 years ago

Currently, the extension tries to find the download links via some way (as in the source code), but this method doesn't work with all the courses.

the script to display techbus download icon has not been touched in a while. it should be working unless o'reilly changed the HTML layout of the courses TOC.

ravikiran-sk commented 5 years ago

Thanks you for your response.

Regarding techbus download icon not sure what has happened. But here is a console screenshot from one of the courses from techbus. For all of the courses it shows the same way. Could you please take a look at it when you have time.

https://techbus.safaribooksonline.com/video/web-applications-and-services/100000006a0643

Thank again for all that you do :)

ravikiran-sk commented 5 years ago

Hey, Just wanted to follow-up

Did you got time to look into the issue with the tech bus site mentioned above?

Thank you

mhewedy commented 5 years ago

I did the investigation ... and I found that the download URLs are there. the issue in displaying the download icon.

These two commits has introduced the issue. I think we need to apply the new code only for the new website and return the old code in case of techbus a.k.a. old website.

mhewedy commented 5 years ago

I've committed the changes to a new branch, but it seems the issue not solved. will give it again soo.

ravikiran-sk commented 5 years ago

Thank you so much for the update.. Please let me know when you fix the issue with techbus. That will be of much help to me :+1:

ravikiran-sk commented 5 years ago

Hi, just wanted to follow-up, Did you tried to fix the download link issue in tech bus site?

jaguni007 commented 5 years ago

I checked with the 2.5 version of the code. It is working. But the the download link is a .xml file and it is forbidden. I think they changed the Download address. Can you solve the issue for techbus.safaribooksonline.com ..??

ravikiran-sk commented 5 years ago

I've committed the changes to a new branch, but it seems the issue not solved. will give it again soo.

Hi, Could you please check the techbus site download issue ?

mhewedy commented 5 years ago

Sorry, I forget about it. I will try to work on it soon, I will add a reminder for myself.

ravikiran-sk commented 5 years ago

Sorry, I forget about it. I will try to work on it soon, I will add a reminder for myself.

Thank you !!! Appreciate your help.. Hope to hear back from you soon.

ravikiran-sk commented 5 years ago

Sorry, I forget about it. I will try to work on it soon, I will add a reminder for myself.

Hello, just following up...Any updates on the techbus download issue?