mheyman / Isopoh.Cryptography.Argon2

Fully managed .Net Core implementation of Argon2
Other
196 stars 9 forks source link

using ntdll.dll for RtlZeroMemory instead of kernel32.dll #24

Closed heikomilke closed 4 years ago

heikomilke commented 4 years ago

we're getting

Unable to find an entry point named 'RtlZeroMemory' in DLL 'kernel32.dll'.
   at Isopoh.Cryptography.SecureArray.DefaultWindowsSecureArrayCall.RtlZeroMemory(Int

when using this lib with dotnetcore 3 on mcr.microsoft.com/dotnet/core/aspnet:3.0.0-nanoserver-1809

fix was inspired by https://github.com/dotnet/coreclr/pull/5554/commits/2a1187d9344639cc343d1e227ee03c6d1eb1e9ca

please consider merging

thanks

mheyman commented 4 years ago

This took me waaay too long to add to the code base. It is here: https://github.com/mheyman/Isopoh.Cryptography.Argon2/blob/3e055f4f661778460edaf17dff813dbbdfb4632e/Isopoh.Cryptography.SecureArray/DefaultWindowsSecureArrayCall.cs#L239 and in the v1.1.4 nuget package. Thanks.